feat: enable Cilium kube-proxy replacement for new clusters #1288
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dkoshkin
force-pushed
the
dkoshkin/feat-cilium-kube-proxy-replacement-new-clusters
branch
from
d5f3ea6 to
742615f
Compare
dkoshkin
force-pushed
the
dkoshkin/feat-cilium-kube-proxy-replacement-new-clusters
branch
from
742615f to
7d79c35
Compare
dkoshkin
commented
Sep 4, 2025
hack/examples/overlays/clusters/aws/cilium/crs/kustomization.yaml.tmpl
Outdated
Show resolved
Hide resolved
jimmidyson
reviewed
Sep 4, 2025
charts/cluster-api-runtime-extensions-nutanix/addons/cni/cilium/values-template.yaml
Show resolved
Hide resolved
charts/cluster-api-runtime-extensions-nutanix/addons/cni/cilium/values-template.yaml
Outdated
Show resolved
Hide resolved
Use the ControlPlane reference in the CAAPH template and check the annotation for skip kube proxy on the referenced control plane object. As per https://cluster-api.sigs.k8s.io/reference/api/metadata-propagation\#cluster-topology the skip proxy annotation will be propagated to the annotations on the referenced control plane so is safe to check. CAAPH adds the referenced control plane to the variables referencable in the Helm values template.
jimmidyson
reviewed
Sep 4, 2025
charts/cluster-api-runtime-extensions-nutanix/addons/cni/cilium/values-template.yaml
Show resolved
Hide resolved
Member
jimmidyson
approved these changes
Sep 4, 2025
jimmidyson
force-pushed
the
dkoshkin/feat-cilium-kube-proxy-replacement-new-clusters
branch
from
ee7933a to
a51ba86
Compare
jimmidyson
reviewed
Sep 4, 2025
hack/examples/overlays/clusters/aws/cilium/helm-addon/kustomization.yaml.tmpl
Show resolved
Hide resolved
CRS generation set the K8S_SERVICE_HOST literally to `auto`. When using the Helm chart, `auto` looks up the host from the `cluster-info` ConfigMap but this is not available when generating the CRS manifests. To use this, we would need to update the CRS templates when applying them to the cluster but we can defer that for now.
jimmidyson
force-pushed
the
dkoshkin/feat-cilium-kube-proxy-replacement-new-clusters
branch
from
2ffb502 to
f4ea809
Compare
jimmidyson
reviewed
Sep 4, 2025
mhrabovcin
approved these changes
Sep 4, 2025
jimmidyson
deleted the
dkoshkin/feat-cilium-kube-proxy-replacement-new-clusters
branch
dkoshkin
added a commit
that referenced
this pull request
Sep 9, 2025
**What problem does this PR solve?**: This PR enables Cilium's kube-proxy replacement feature automatically when clusters disable kube-proxy installation during upgrades. The Cilium handler will apply the new configuration, wait for the DaemonSet to be rolled out and then delete the kube-proxy DaemonSet and its ConfigMap. **Which issue(s) this PR fixes**: Fixes # **How Has This Been Tested?**: <!-- Please describe the tests that you ran to verify your changes. Provide output from the tests and any manual steps needed to replicate the tests. --> **Special notes for your reviewer**: <!-- Use this to provide any additional information to the reviewers. This may include: - Best way to review the PR. - Where the author wants the most review attention on. - etc. --> Stacked on #1288
Merged
This was referenced Oct 22, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What problem does this PR solve?:
This PR enables Cilium's kube-proxy replacement feature automatically when clusters disable kube-proxy installation for new clusters.
Which issue(s) this PR fixes:
Fixes #
How Has This Been Tested?:
Special notes for your reviewer: